From: Jeff King Date: Fri, 21 Feb 2020 05:26:33 GMT Subject: Re: [PATCH v3 1/2] submodule--helper: use C99 named initializer Message-ID: <20200221052633.GA1280313@coredump.intra.peff.net> In-Reply-To: <20200221031027.204486-2-emilyshaffer@google.com> On Thu, Feb 20, 2020 at 07:10:26PM -0800, Emily Shaffer wrote: > Start using a named initializer list for SUBMODULE_UPDATE_CLONE_INIT, as > the struct is becoming cumbersome for a typical struct initializer list. Much nicer. :) I manually compared the struct declaration to the existing initializer to double-check that you counted the offsets correctly, and all looks good. -Peff