From: Emily Shaffer <emilyshaffer@google.com>
Date: Fri, 14 Feb 2020 01:20:37 GMT
Subject: Re: [PATCH v6 01/15] help: move list_config_help to builtin/help
Message-ID: <20200214012037.GK190927@google.com>
In-Reply-To: <CAPig+cT3gSARiHFN=79Z_BBACDyOqW8nZ+7RwODAmLrDv1SHuA@mail.gmail.com>

On Thu, Feb 13, 2020 at 06:29:39PM -0500, Eric Sunshine wrote:
> On Thu, Feb 13, 2020 at 6:24 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Eric Sunshine <sunshine@sunshineco.com> writes:
> > > On Thu, Feb 13, 2020 at 5:58 PM Emily Shaffer <emilyshaffer@google.com> wrote:
> > >> Thanks for the suggestion. You're right that I didn't look into the
> > >> contents of this script much, because I was just moving it; I modified
> > >> your sed expression slightly so it performs just one operation:
> > >>
> > >>   sed 's/^.*$/    "\0",/'
> > >
> > > This isn't portable and won't work with 'sed' from BSD lineage,
> > > including Mac OS. More portable would be:
> > >
> > >     sed 's/^\(.*\)$/    "\1",/'
> >
> > Or just replace Emily's \0 with &; that should be in POSIX.
> 
> Yes, that's nicer.

Sure, thanks.