From: Jeff King <peff@peff.net>
Date: Thu, 30 Jan 2020 07:29:57 GMT
Subject: Re: [PATCH v3 10/12] sparse-checkout: write escaped patterns in cone mode
Message-ID: <20200130072957.GE2189233@coredump.intra.peff.net>
In-Reply-To: <7a85cded-eccf-9f33-4056-08b2923b2861@gmail.com>

On Wed, Jan 29, 2020 at 09:16:11AM -0500, Derrick Stolee wrote:

> I've applied the smaller comments and am now investigating the right
> thing to do with other is_glob_special() characters. There is a small
> chance that I can replace any "c == '*' || c == '\'" with is_glob_special(),
> but we shall see. At the very least, I'll need to expand my tests.

Yeah, that's all I'd expect to need. You mentioned earlier about how
ls-tree would output them, but I don't think it would matter. Now that
you're using unquote_c_style(), you'll get the literal filenames no
matter which way ls-tree decides to quote them (and I don't think it
would quote '?', just as it wouldn't '*', because those are not
syntactically significant in its output).

-Peff