From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sat, 25 Jan 2020 22:43:28 GMT
Subject: Re: [PATCH] t5616: make robust to delta base change
Message-ID: <20200125224328.GC4113372@camp.crustytoothpaste.net>
In-Reply-To: <20200113202823.228062-1-jonathantanmy@google.com>

On 2020-01-13 at 20:28:23, Jonathan Tan wrote:
> Commit 6462d5eb9a ("fetch: remove fetch_if_missing=0", 2019-11-08)
> contains a test that relies on having to lazily fetch the delta base of
> a blob, but assumes that the tree being fetched (as part of the test) is
> sent as a non-delta object. This assumption may not hold in the future;
> for example, a change in the length of the object hash might result in
> the tree being sent as a delta instead.
> 
> Make the test more robust by relying on having to lazily fetch the delta
> base of the tree instead, and by making no assumptions on whether the
> blobs are sent as delta or non-delta.
> 
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>

Junio, I think this patch may not have gotten picked up.  It fixes my
problem with SHA-256 and makes the test more robust, and it didn't
appear that anyone else had objections to it, so I think it may be
ready.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204