From: Eric Wong Date: Thu, 26 Dec 2019 18:59:32 GMT Subject: Re: [PATCH 2/2] packfile: replace lseek+read with pread Message-ID: <20191226185932.GA19165@dcvr> In-Reply-To: Junio C Hamano wrote: > Eric Wong writes: > > > > Furthermore, readers of the packfile will be using mmap > > (or pread to emulate mmap), anyways, so the file description > > offset does not matter in this case. > > s/description/descriptor/ probably. No, I meant "description" :) The offset is shared in case of dup{,2,3} syscalls, which only creates a new descriptor, not a new description. Both the Linux and POSIX lseek(2) manpages say "description".