From: Jeff King <peff@peff.net>
Date: Sat, 14 Dec 2019 01:00:02 GMT
Subject: Re: [PATCH] Makefile: drop GEN_HDRS
Message-ID: <20191214010002.GA945704@coredump.intra.peff.net>
In-Reply-To: <20191214003820.GA927924@coredump.intra.peff.net>

On Fri, Dec 13, 2019 at 07:38:21PM -0500, Jeff King wrote:

> That's because LIB_H is created by running find in the local filesystem.
> So until it's generated, we don't realize it's there to check. I kind of
> wonder if it should be part of LIB_H. I suspect that on some systems,
> we'd fail to notice a rebuild when command-list.txt is updated (but
> nobody noticed, because it is only systems that do not have
> compiler-supported dependency tracking, and most developers are no
> modern platforms that do).

Actually, this probably isn't true. We have an explicit dependency for
help.o on command-list.h, so it would get built properly then.

Its inclusion in LIB_H is still wonky, though. It sometimes is included
and sometimes not, depending on whether ls-files or find is used.

-Peff