From: Jeff King <peff@peff.net>
Date: Mon, 09 Dec 2019 06:24:49 GMT
Subject: Re: [PATCH v3 1/9] builtin/pack-objects: report reused packfile objects
Message-ID: <20191209062449.GA40570@coredump.intra.peff.net>
In-Reply-To: <20191115141541.11149-2-chriscool@tuxfamily.org>

On Fri, Nov 15, 2019 at 03:15:33PM +0100, Christian Couder wrote:

> From: Jeff King <peff@peff.net>
> 
> To see when packfile reuse kicks in or not, it is useful to
> show reused packfile objects statistics in the output of
> upload-pack.

Yep, I think this one makes sense. I would be a bit curious to see how
often reuse actually kicks in for you with the current code. Back when I
worked on this topic in 2015, it was kicking in for us almost-never (at
least for big repos like torvalds/linux that we were interested in
measuring), but that's because we were packing all of the forks together
(and still do). The earlier heuristics made no sense for that case.

I don't know if it's really worth spending a lot of time trying to
collect data, though.

-Peff