From: Miriam Rubio Date: Sun, 08 Dec 2019 17:28:13 GMT Subject: [Outreachy] [PATCH] bisect--helper: refer branch.buf before strbuf_release(...) Message-ID: <20191208172813.16518-1-mirucam@gmail.com> From: Tanushree Tumane Move `error("...%s...", branch.buf);` before `strbuf_release(&branch);` to release string buffer `branch` and the memory it used. Mentored-by: Johannes Schindelin Mentored-by: Christian Couder Signed-off-by: Tanushree Tumane Signed-off-by: Miriam Rubio --- builtin/bisect--helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 1fbe156e67..3055b2bb50 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -169,11 +169,12 @@ static int bisect_reset(const char *commit) argv_array_pushl(&argv, "checkout", branch.buf, "--", NULL); if (run_command_v_opt(argv.argv, RUN_GIT_CMD)) { + error(_("could not check out original" + " HEAD '%s'. Try 'git bisect" + " reset '."), branch.buf); strbuf_release(&branch); argv_array_clear(&argv); - return error(_("could not check out original" - " HEAD '%s'. Try 'git bisect" - " reset '."), branch.buf); + return -1; } argv_array_clear(&argv); } -- 2.21.0 (Apple Git-122.2)