From: Danh Doan <congdanhqx@gmail.com>
Date: Sat, 30 Nov 2019 10:48:12 GMT
Subject: Re: [PATCH v5 26/26] t7700: stop losing return codes of git commands
Message-ID: <20191130104812.GA18401@danh.dev>
In-Reply-To: <1f6d9a80ad45fd9f51c8cffe9ce3721fce9b80c0.1574884302.git.liu.denton@gmail.com>


Hi Denton,

On 2019-11-27 11:54:04-0800, Denton Liu <liu.denton@gmail.com> wrote:
> -	test 0 = $(git verify-pack -v -- .git/objects/pack/*.idx |
> -		grep "^$coid " | sort | uniq | wc -l) &&
> +	git verify-pack -v -- .git/objects/pack/*.idx >packlist &&
> +	! grep "^$coid " packlist &&

I think we want to use test_must_fail instead of !

>  	echo >.git/objects/info/alternates &&
>  	test_must_fail git show $coid
>  '
> @@ -151,8 +150,8 @@ test_expect_success 'local packed unreachable obs that exist in alternate ODB ar
>  	    --unpack-unreachable </dev/null pack &&
>  	rm -f .git/objects/pack/* &&
>  	mv pack-* .git/objects/pack/ &&
> -	test 0 = $(git verify-pack -v -- .git/objects/pack/*.idx |
> -		grep "^$coid " | sort | uniq | wc -l) &&
> +	git verify-pack -v -- .git/objects/pack/*.idx >packlist &&
> +	! grep "^$coid " &&

ditto

-- 
Danh