From: Jonathan Tan Date: Wed, 27 Nov 2019 18:02:10 GMT Subject: Re: [PATCH v2 02/13] t6120-describe: modernize the 'check_describe' helper Message-ID: <20191127180210.168901-1-jonathantanmy@google.com> In-Reply-To: <20191112103821.30265-3-szeder.dev@gmail.com> > The 'check_describe' helper function runs 'git describe' outside of > 'test_expect_success' blocks, with extra hand-rolled code to record > and examine its exit code. > > Update this helper and move the 'git decribe' invocation inside the > 'test_expect_success' block. decribe -> describe Otherwise, patches 1 and 2 are relatively straightforward and look good to me.