From: Jeff King <peff@peff.net>
Date: Mon, 25 Nov 2019 13:19:51 GMT
Subject: Re: [PATCH] test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'
Message-ID: <20191125131951.GA494@sigill.intra.peff.net>
In-Reply-To: <20191125125907.28967-1-szeder.dev@gmail.com>

On Mon, Nov 25, 2019 at 01:59:07PM +0100, SZEDER Gábor wrote:

> When 'test_commit_bulk' is invoked in an empty test repository, it
> prints a "fatal: Needed a single revision" error, but still does what
> it's supposed to do.  A test helper function displaying a fatal error
> and still succeeding is always suspect to be buggy, but luckily that's
> not the case here: that error comes from a 'git rev-parse --verify
> HEAD' command invoked in a condition, which doesn't have anything to
> verify in an empty repository.
> 
> Use the '--quiet' option to suppress that error message.

Yep, makes perfect sense. Thanks.

-Peff