From: Jeff King Date: Fri, 15 Nov 2019 09:06:01 GMT Subject: [PATCH 2/4] t/gitweb-lib.sh: drop confusing quotes Message-ID: <20191115090601.GB21987@sigill.intra.peff.net> In-Reply-To: <20191115090545.GA30971@sigill.intra.peff.net> Some variables assignments in gitweb_run() look like this: FOO=""$1"" The extra quotes aren't doing anything. Each set opens and closes an empty string, and $1 is actually outside of any double-quotes (which is OK, because variable assignment does not do whitespace splitting on the expanded value). Let's drop them, as they're simply confusing. Signed-off-by: Jeff King --- t/gitweb-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh index 006d2a8152..130c7ed64f 100644 --- a/t/gitweb-lib.sh +++ b/t/gitweb-lib.sh @@ -58,8 +58,8 @@ gitweb_run () { GATEWAY_INTERFACE='CGI/1.1' HTTP_ACCEPT='*/*' REQUEST_METHOD='GET' - QUERY_STRING=""$1"" - PATH_INFO=""$2"" + QUERY_STRING=$1 + PATH_INFO=$2 export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \ QUERY_STRING PATH_INFO -- 2.24.0.739.gb5632e4929