From: Jeff King <peff@peff.net>
Date: Fri, 01 Nov 2019 16:54:15 GMT
Subject: Re: [PATCH v2 1/3] t0028: eliminate non-standard usage of printf
Message-ID: <20191101165415.GB26219@sigill.intra.peff.net>
In-Reply-To: <8b3002842537355c2387cb55f52c10ad8a7dd530.1572596278.git.congdanhqx@gmail.com>

On Fri, Nov 01, 2019 at 03:25:09PM +0700, Doan Tran Cong Danh wrote:

> man 1p printf:
>    In addition to the escape sequences shown in the Base Definitions
>    volume of POSIX.1‐2008, Chapter 5, File Format Notation ('\\',
>    '\a', '\b', '\f', '\n', '\r', '\t', '\v'), "\ddd", where ddd is a
>    one, two, or three-digit octal number, shall be written as a byte
>    with the numeric value specified by the octal number.
> 
> printf '\xfe\xff' in an extension of some shell.

Typo: s/in/is/

Other than that, this looks great to me. Thanks.

-Peff