From: Stephen Boyd <sboyd@kernel.org>
Date: Sun, 20 Oct 2019 18:27:08 GMT
Subject: Re: [PATCH v2] userdiff: Fix some corner cases in dts regex
Message-ID: <20191020182709.CC74A218BA@mail.kernel.org>
In-Reply-To: <4f8e8a13-c41f-558f-18c3-b2bda178a06b@kdbg.org>

Quoting Johannes Sixt (2019-10-16 14:10:09)
> [Removed bouncing addresses of Matthieu Moy and William Duclot from Cc]
> 
> Am 16.10.19 um 22:32 schrieb Stephen Boyd:
> > diff --git a/t/t4018/dts-nodes-multiline-prop b/t/t4018/dts-nodes-multiline-prop
> > new file mode 100644
> > index 000000000000..db4b4bdda686
> > --- /dev/null
> > +++ b/t/t4018/dts-nodes-multiline-prop
> > @@ -0,0 +1,14 @@
> > +/ {
> > +     label_1: node1@ff00 {
> > +             RIGHT@deadf00,4000 {
> > +                     multilineprop = <3>,
> > +
> > +
> > +                                     <4>;
> 
> I was actually thinking about something like
> 
>                         multilineprop = <3>,
>                                         <0xabcd>,
>                                         "text",
>                                         name,
>                                         <4>;
> 
> or something like that -- whatever occurs in the real world.
> 

Ok sure. I can have a list of numbers that spans four or five lines.

> > +
> > +
> > +
> > +                     ChangeMe = <0xffeedd00>;
> > +             };
> > +     };
> > +};
> 
> Apart from that, the patch looks good.
> 

Cool. I'll resend.