From: Jeff King Date: Thu, 17 Oct 2019 06:35:55 GMT Subject: Re: [PATCH 6/6] index-pack: make quantum of work smaller Message-ID: <20191017063554.GG10862@sigill.intra.peff.net> In-Reply-To: <505d8e79cd983d5b3dfd56c4f0432ad647132957.1570663470.git.jonathantanmy@google.com> On Wed, Oct 09, 2019 at 04:44:22PM -0700, Jonathan Tan wrote: > Signed-off-by: Jonathan Tan > --- > builtin/index-pack.c | 267 ++++++++++++++++++++----------------------- > 1 file changed, 127 insertions(+), 140 deletions(-) I think this is a good direction to go in. I confess I didn't carefully go over the implementation details, since you've marked this as RFC and it sounds like you're mainly asking about direction. It looks pretty reasonable from a high level, though. -Peff