From: Jeff King <peff@peff.net>
Date: Thu, 17 Oct 2019 06:30:43 GMT
Subject: Re: [PATCH 4/6] index-pack: calculate {ref,ofs}_{first,last} early
Message-ID: <20191017063043.GE10862@sigill.intra.peff.net>
In-Reply-To: <0f0ffe71c5df9129a04546b8e3ed13a3ece1b9b1.1570663470.git.jonathantanmy@google.com>

On Wed, Oct 09, 2019 at 04:44:20PM -0700, Jonathan Tan wrote:

> Whenever we make a struct base_data, immediately calculate its delta
> children. This eliminates confusion as to when the
> {ref,ofs}_{first,last} fields are initialized.

That _seems_ like a good idea, but I'm a little worried just because I
don't entirely understand why it was being done lazily before. If you've
puzzled all that out, it would be nice to make the argument in the
commit message.

-Peff