From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Fri, 20 Sep 2019 18:14:07 GMT
Subject: Re: [PATCH 08/15] name-rev: pull out deref handling from the recursion
Message-ID: <20190920181407.GB26402@szeder.dev>
In-Reply-To: <20190920181302.GA26402@szeder.dev>

On Fri, Sep 20, 2019 at 08:13:02PM +0200, SZEDER Gábor wrote:
> > If the (re)introduced leak doesn't impact performance and memory
> > usage too much then duplicating tip_name again in name_rev() or
> > rather your new create_or_update_name() would likely make the
> > lifetimes of those string buffers easier to manage.
> 
> Yeah, the easiest would be when each 'struct rev_name' in the commit
> slab would have its own 'tip_name' string, but that would result in
> a lot of duplicated strings and increased memory usage.

I didn't measure how much more memory would be used, though.