From: SZEDER Gábor Date: Mon, 16 Sep 2019 22:36:07 GMT Subject: Re: [PATCH v2 1/1] commit-graph: add --[no-]progress to write and verify. Message-ID: <20190916223607.GE6190@szeder.dev> In-Reply-To: <47cc99bd151db67fe2ee0f91bb98b3eb7e55786d.1566836997.git.gitgitgadget@gmail.com> On Mon, Aug 26, 2019 at 09:29:58AM -0700, Garima Singh via GitGitGadget wrote: > From: Garima Singh > > Add --[no-]progress to git commit-graph write and verify. > The progress feature was introduced in 7b0f229 > ("commit-graph write: add progress output", 2018-09-17) but > the ability to opt-out was overlooked. > diff --git a/t/t5324-split-commit-graph.sh b/t/t5324-split-commit-graph.sh > index 99f4ef4c19..4fc3fda9d6 100755 > --- a/t/t5324-split-commit-graph.sh > +++ b/t/t5324-split-commit-graph.sh > @@ -319,7 +319,7 @@ test_expect_success 'add octopus merge' ' > git merge commits/3 commits/4 && > git branch merge/octopus && > git commit-graph write --reachable --split && > - git commit-graph verify 2>err && > + git commit-graph verify --progress 2>err && Why is it necessary to use '--progress' here? It should not be necessary, because the commit message doesn't mention that it changed the default behavior of 'git commit-graph verify'... > test_line_count = 3 err && Having said that, this test should not check the number of progress lines in the first place; see the recent discussion: https://public-inbox.org/git/ec14865f-98cb-5e1a-b580-8b6fddaa6217@gmail.com/ > test_i18ngrep ! warning err && > test_line_count = 3 $graphdir/commit-graph-chain > -- > gitgitgadget