From: Jeff King <peff@peff.net>
Date: Wed, 28 Aug 2019 15:39:44 GMT
Subject: Re: [PATCH 1/1] upload-pack: fix race condition in error messages
Message-ID: <20190828153944.GA29715@sigill.intra.peff.net>
In-Reply-To: <20190828145412.GB14432@sigill.intra.peff.net>

On Wed, Aug 28, 2019 at 10:54:12AM -0400, Jeff King wrote:

> > Unfortunately, however, while running './t5516-fetch-push.sh -r 1,79
> > --stress' to try to reproduce a failure caused by those mingled
> > messages, the same check only failed for a different reason so far
> > (both on Linux and macOS (on Travis CI)):
> 
> There's some hand-waving argument that this should be race-free in
> 014ade7484 (upload-pack: send ERR packet for non-tip objects,
> 2019-04-13), but I am not too surprised if there is a flaw in that
> logic.

By the way, I've not been able to reproduce this locally after ~10
minutes of running "./t5516-fetch-push.sh -r 1,79 --stress" on my Linux
box. I wonder what's different.

Are you running the tip of master?

-Peff