From: Denton Liu Date: Sat, 24 Aug 2019 08:03:28 GMT Subject: Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option Message-ID: <20190824080328.GA9726@archbookpro.localdomain> In-Reply-To: On Fri, Aug 23, 2019 at 01:18:44PM -0700, Junio C Hamano wrote: > Philip Oakley writes: > > > Perhaps the `--infer-cover-subject` the config option needs to be > > multi-valued to include: > >      "subject" (always expect short first lines) or > >      "message" (always the long paragraph description, still use > > ***Subject Here***), > >      with the "true" being used when expecting both as previously > > described. Good idea, I like this a lot! > > The idea to have three choices feels that this is getting better, > but I notice that the choice is no longer about "subject". > > I've always felt that the name of this option is way suboptimal. > One reason is because the option only says it is about the subject > of the cover (letter), and the verb "infer" conveys almost no > information---especially it does not say anything about what affects > the inference (hint: the branch description value gets used, in a > single hardcoded ways right now, but now with the patch we have a > choice to control how it gets used). Perhaps something like --cover-subject-from-description={true,auto,false}?