From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sun, 18 Aug 2019 20:34:18 GMT
Subject: Re: [PATCH 11/14] t3903: abstract away SHA-1-specific constants
Message-ID: <20190818203417.GG365197@genre.crustytoothpaste.net>
In-Reply-To: <CAPig+cT6Depk8sJ48zOp6+AObVmy3_eXnXPEsZJYXY=daZqXXQ@mail.gmail.com>

On 2019-08-18 at 20:27:41, Eric Sunshine wrote:
> For safety, it would probably be a good idea to check the exit status
> of the 'sed' invocation in the for-loop:
> 
>     for i in "$1" "$2"
>     do
>         sed -e ... "$i" >"$i.compare" || return 1
>     done &&
>     ...

I'll do that.

> (Note, also, that I dropped the whitespace after the '>' operator.)

Ah, good catch.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204