From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 13 Aug 2019 22:48:34 GMT
Subject: Re: [PATCH v3 2/2] apply: reload .gitattributes after patching it
Message-ID: <20190813224834.GB229582@genre.crustytoothpaste.net>
In-Reply-To: <xmqq36i47ku3.fsf@gitster-ct.c.googlers.com>

On 2019-08-13 at 22:37:56, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > +test_expect_success 'rebase --am and .gitattributes' '
> > +	test_create_repo attributes &&
> > +	(
> > +		cd attributes &&
> > +		test_commit init &&
> > +		test_config filter.test.clean "sed -e '\''s/smudged/clean/g'\''" &&
> > +		test_config filter.test.smudge "sed -e '\''s/clean/smudged/g'\''" &&
> 
> These eventually invokes test-when-finished for cleaning things up,
> that cannot be called inside a subshell.  The "attributes" test
> repository is a throw-away reopsitory, so we should be able to just
> use "git config" to set the variables locally in it, no?

Yup, that's safe. I'll reroll with that.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204