From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Mon, 05 Aug 2019 10:14:07 GMT
Subject: Re: [PATCH 0/3] commit-graph: error out on invalid commit oids in 'write --stdin-commits'
Message-ID: <20190805101407.GB20404@szeder.dev>
In-Reply-To: <20190805080240.30892-1-szeder.dev@gmail.com>

On Mon, Aug 05, 2019 at 10:02:37AM +0200, SZEDER Gábor wrote:
> While 'git commit-graph write --stdin-commits' expects commit object
> ids as input, it accepts and silently skips over any invalid commit
> object ids, and still exits with success:
> 
>   $ echo not-a-commit-oid | git commit-graph write --stdin-commits
>   $ echo $?

Oh, messed up the copy-paste; this prints 0.

>   $ ls -l .git/objects/info/commit-graph
>   ls: cannot access '.git/objects/info/commit-graph': No such file or directory