From: Jeff King Date: Mon, 05 Aug 2019 04:21:04 GMT Subject: Re: [PATCH v2] l10n: reformat some localized strings for v2.23.0 Message-ID: <20190805042104.GA30941@sigill.intra.peff.net> In-Reply-To: <5200616.dDItsc6b64@cayenne> On Sun, Aug 04, 2019 at 01:01:51PM +0200, Jean-Noël AVILA wrote: > This one is not about typos. > > My original fix was more concerning the second sequence, where the > sentence is broken in the middle, simply for better rendering but this > does not make sense either, because the lines are too long anyway. Ah, yeah, the sentence broken over the line is pretty bad for translation. And I agree the lines are overly long. > Is it so important that the lines of warning all start with a > "warning:" prefix? For some definition of "so". ;) As I said, I think your patch may be the lesser of two evils, and we should take it until warning() learns to handle lines breaks better. -Peff