From: Todd Zullinger Date: Wed, 31 Jul 2019 06:04:49 GMT Subject: Re: [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop Message-ID: <20190731060449.GE4545@pobox.com> In-Reply-To: <20190731032735.GA14684@sigill.intra.peff.net> Jeff King wrote: > On Tue, Jul 30, 2019 at 09:59:17PM -0400, Todd Zullinger wrote: >> At the risk of showing my complete lack of knowledge about >> these tests, I was wondering if the order mattered for the >> other tests in t0011 and t0016. [...] >> You've got a more comprehensive patch and a proper commit >> message, so this is really just a matter of curiosity. > > I think the order does matter for those ones. E.g., the ones that run > "get" want to make sure they're seeing the values in the same order in > which they were requested. Ahh, thanks for clarifying that (and saving me from sending the version I had which would have incorrectly sorted all the test_{hashmap,oidmap} output. :) FWIW, I applied your patch for sorting hashmap iterations (<20190731012336.GA13880@sigill.intra.peff.net>¹) and ran it through the Fedora build system. All architectures passed, as expected. ¹ https://public-inbox.org/git/20190731012336.GA13880@sigill.intra.peff.net/ -- Todd