From: SZEDER Gábor Date: Thu, 18 Jul 2019 23:46:47 GMT Subject: Re: [PATCH v2] transport-helper: enforce atomic in push_refs_with_push Message-ID: <20190718234647.GJ20404@szeder.dev> In-Reply-To: On Thu, Jul 18, 2019 at 09:12:52AM -0700, Junio C Hamano wrote: > SZEDER Gábor writes: > > > With that patch issues like this could be caught earlier, while they > > are only in 'pu' but not yet in 'next'. But do we really want to do > > that, is that the right tradeoff? > > I am sort of in favor of having at least one build with an older > compiler without "-std=c99", like the set-up you are proposing. Alternatively, we could sort-of restore the old state of the GETTEXT_POISON job, i.e. build Git with GCC 4.8 in that job. "Sort-of", because we don't necessarily have to go back to the Ubuntu 14.04 based Linux image, because GCC 4.8 is packaged in 16.04 as well, so it's just an 'apt-get install gcc-4.8' away.