From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Wed, 03 Jul 2019 16:50:36 GMT
Subject: Re: [PATCH v2 2/2] check_everything_connected: assume alternate ref tips are valid
Message-ID: <20190703165036.GS21574@szeder.dev>
In-Reply-To: <20190703164116.GA23260@sigill.intra.peff.net>

On Wed, Jul 03, 2019 at 12:41:16PM -0400, Jeff King wrote:
> On Wed, Jul 03, 2019 at 11:12:25AM +0200, SZEDER Gábor wrote:
> 
> > On Mon, Jul 01, 2019 at 09:18:15AM -0400, Jeff King wrote:
> > > diff --git a/t/t5618-alternate-refs.sh b/t/t5618-alternate-refs.sh
> > > new file mode 100755
> > > index 0000000000..3353216f09
> > > --- /dev/null
> > > +++ b/t/t5618-alternate-refs.sh
> > > @@ -0,0 +1,60 @@
> > 
> > > +test_expect_success 'log --source shows .alternate marker' '
> > > +	git log --oneline --source --remotes=origin >expect.orig &&
> > > +	sed "s/origin.* /.alternate /" <expect.orig >expect &&
> > 
> > Unnecessary redirection, 'sed' can open that file on its own as well.
> 
> Sure, but is there a compelling reason not to feed it as stdin?

Not really, other than there is no compelling reason to do so :)