From: Jeff King <peff@peff.net>
Date: Fri, 28 Jun 2019 10:18:58 GMT
Subject: Re: [PATCH] check_everything_connected: assume alternate ref tips are valid
Message-ID: <20190628101858.GA23052@sigill.intra.peff.net>
In-Reply-To: <20190628101131.GA22862@sigill.intra.peff.net>

On Fri, Jun 28, 2019 at 06:11:31AM -0400, Jeff King wrote:

> Subject: [PATCH] check_everything_connected: assume alternate ref tips...

Heh. This subject should just be "check_connected" these days. I wrote
this patch originally many years ago, before 7043c7071c
(check_everything_connected: use a struct with named options,
2016-07-15) gave the function a shorter name.

But the patch has been updated recently to match other updates to the
alternates code. In particular, in the original "rev-list
--alternate-refs" behaved as if all of the refs from the alternate were
mentioned on the command line, and you could use --exclude, etc as if
they were real refs. But we've since simplified the alternates interface
to just get a list of oids, so now it behaves more like
"--indexed-objects" in that it acts as if those oids were mentioned on
the command line.

I think "--alternate-refs" is still the right name, though, since we're
just giving the oids at the ref tips. And I think the included
documentation makes this clear.

-Peff