From: Matthew DeVore <matvore@comcast.net>
Date: Thu, 27 Jun 2019 21:17:04 GMT
Subject: Re: [PATCH v4 06/10] list-objects-filter-options: make filter_spec a string_list
Message-ID: <20190627211704.GC54617@comcast.net>
In-Reply-To: <20190622003713.248581-1-jonathantanmy@google.com>

On Fri, Jun 21, 2019 at 05:37:13PM -0700, Jonathan Tan wrote:
> Patch 5 and this patch look good to me.
> 
> <snip>
> 
> So expand_list_objects_filter_spec() now returns a filter_options-owned
> string (instead of previously writing to a strbuf), which is why we no
> longer need to do any freeing or releasing. That makes sense. (Same for
> the other call sites.)
> 
> <snip>
> 
> This append needs to be called with xstrdup, because a zero-initialized
> string list is NODUP. OK.

Thank you for taking a look.