From: Rohit Ashiwal Date: Fri, 14 Jun 2019 03:43:56 GMT Subject: Re: [GSoC][PATCH v3 1/3] sequencer: add advice for revert Message-ID: <20190614034356.19073-1-rohit.ashiwal265@gmail.com> In-Reply-To: <0333fe2f-d68a-4536-c736-ca2a356df34b@gmail.com> Hi Phillip On 2019-06-13 17:45 UTC Phillip Wood wrote: > >> + break; >> + default: >> + BUG(_("the control must not reach here")); > > This does not need to be translated as BUG() messages are not really for > users. Everything else looks fine to be now I know this is not intended for the users, but seeing a message like this a user might think to report it to the team with the steps for reproducing the BUG. Yes, I agree this needs a little bit of re-wording. > Best Wishes > > Phillip Thanks Rohit