From: Mike Hommey <mh@glandium.org>
Date: Thu, 16 May 2019 00:31:30 GMT
Subject: Re: Closing fds twice when using remote helpers
Message-ID: <20190516003130.racexnofe7cxra3t@glandium.org>
In-Reply-To: <20190515105609.sucfjvuumeyyrmjb@glandium.org>

On Wed, May 15, 2019 at 07:56:09PM +0900, Mike Hommey wrote:
> Hi,
> 
> I started getting a weird error message during some test case involving
> git-cinnabar, which is a remote-helper to access mercurial
> repositories.
> 
> The error says:
> fatal: mmap failed: Bad file descriptor
> 
> ... which was not making much sense. Some debugging later, and it turns
> out this is what happens:
> 
> - start_command is called for fast-import
> - start_command is called again for git-remote-hg, passing the
>   fast_import->out as cmd->in.

My mistake, it's the opposite: start_command for fast-import is called
with the out of git-remote-hg as in.

Anyways, patches incoming.

Mike