From: Jeff King Date: Thu, 09 May 2019 21:30:19 GMT Subject: [PATCH 06/14] wt-status: drop unused status parameter Message-ID: <20190509213019.GF15837@sigill.intra.peff.net> In-Reply-To: <20190509212558.GA15438@sigill.intra.peff.net> The v2_fix_up_changed() function doesn't actually need to see the wt_status struct. It's possible that could change in the future, but this is a static-local function with one caller. It would be easy to read-add it back then. Let's drop the unused parameter. Signed-off-by: Jeff King --- wt-status.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/wt-status.c b/wt-status.c index f4fa982638..4c365ca6fd 100644 --- a/wt-status.c +++ b/wt-status.c @@ -2045,9 +2045,7 @@ static void wt_porcelain_v2_submodule_state( /* * Fix-up changed entries before we print them. */ -static void wt_porcelain_v2_fix_up_changed( - struct string_list_item *it, - struct wt_status *s) +static void wt_porcelain_v2_fix_up_changed(struct string_list_item *it) { struct wt_status_change_data *d = it->util; @@ -2107,7 +2105,7 @@ static void wt_porcelain_v2_print_changed_entry( char submodule_token[5]; char sep_char, eol_char; - wt_porcelain_v2_fix_up_changed(it, s); + wt_porcelain_v2_fix_up_changed(it); wt_porcelain_v2_submodule_state(d, submodule_token); key[0] = d->index_status ? d->index_status : '.'; -- 2.21.0.1382.g4c6032d436