From: Jeff King <peff@peff.net>
Date: Fri, 05 Apr 2019 19:25:35 GMT
Subject: Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations
Message-ID: <20190405192534.GA4496@sigill.intra.peff.net>
In-Reply-To: <c21b923f-54aa-defa-ecfd-11ecd6f8a664@ramsayjones.plus.com>

On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote:

> >  /* global flag to enable extra checks when accessing packed objects */
> > -extern int do_check_packed_object_crc;
> > +int do_check_packed_object_crc;
> 
> ... removing this 'extern' on an int variable sends 'sparse'
> into a frenzy of warnings! :-D
> 
> [You didn't use a global s/extern// by any chance?]

Oh my. I did look at each one, but probably via replace-and-confirm in
vim. I don't know how I managed to botch that one so badly.

-Peff