From: Jeff King <peff@peff.net>
Date: Tue, 26 Mar 2019 16:24:27 GMT
Subject: Re: [PATCH v2 0/6] Asciidoctor-related formatting and CI fixes
Message-ID: <20190326162427.GB29627@sigill.intra.peff.net>
In-Reply-To: <20190324215534.9495-1-szeder.dev@gmail.com>

On Sun, Mar 24, 2019 at 10:55:28PM +0100, SZEDER Gábor wrote:

> The first three patches fix formatting issues with Asciidoctor; they
> are the same patches that I sent earlier today, except some commit
> message updates (now they mention the Asciidoctor version which
> started to issue the warning, and I fixed that missing half-sentence
> in one of the commit messages).
> 
> The last three patches are a small cleanup and fixes to the
> documentation CI build jobs; notably patch 5 un-breaks the
> documentation build job on Travis CI in the era of Asciidoctor v2.0.0
> [1], and patch 5 fixes some forever-broken checks.
> 
> The formatting and CI fixes are not really related, but the check
> fixed in patch 6 would choke without the formatting fixes silencing
> warnings from Asciidoctor, that's why I send them in the same patch
> series.

Thanks, these all look good to me (I do agree with Dscho that the
"Documentation" subtlety in patch 4 might be worth calling out in the
commit message).

-Peff