From: Jeff King <peff@peff.net>
Date: Fri, 22 Mar 2019 03:48:37 GMT
Subject: Re: [PATCH v2] stash: setup default diff output format if necessary
Message-ID: <20190322034837.GA20091@sigill.intra.peff.net>
In-Reply-To: <xmqqtvfvr3oi.fsf@gitster-ct.c.googlers.com>

On Fri, Mar 22, 2019 at 12:25:17PM +0900, Junio C Hamano wrote:

> > There is a "set_default" callback that was added by 6c374008b1
> > (diff_opt: track whether flags have been set explicitly, 2013-05-10),
> > but it looks like it was never actually used. I think the theory is that
> > cases like this could do their tweaking in such a callback. But I think
> > it makes sense to follow the lead of builtin/diff.c for the immediate
> > fix, and we can look at using set_default as a separate topic.
> 
> I agree with the conclusion.  I wouldn't be surprised if this is one
> of the things that was once used but left behind when the last
> caller disappeared, though.

I wondered, too, but `git log --pickaxe-regex -S'set_default[^_]'` seems
to think it was purely aspirational. :)

That calls for a little extra caution when starting to use it (because
it has not really been tested), but from a quick look I cannot see how
it would go wrong.

-Peff