From: Jeff King Date: Tue, 19 Mar 2019 06:20:35 GMT Subject: Re: [PATCH v3 6/8] reflog tests: assert lack of early exit with expiry="never" Message-ID: <20190319062034.GA31801@sigill.intra.peff.net> In-Reply-To: <20190315155959.12390-7-avarab@gmail.com> On Fri, Mar 15, 2019 at 04:59:57PM +0100, Ævar Arnfjörð Bjarmason wrote: > When gc.reflogExpire and gc.reflogExpireUnreachable are set to "never" > and --stale-fix isn't in effect (covered by the first part of the "if" > statement being modified here) we *could* exit early without > pointlessly looping over all the reflogs. Er, which "if" statement are we modifying here? :) I assume this is leftover from the earlier attempt which actually did modify it. -Peff