From: Josh Steadmon Date: Fri, 15 Mar 2019 20:49:19 GMT Subject: Re: [PATCH 2/2] trace2: randomize/timestamp trace2 targets Message-ID: <20190315204919.GF47591@google.com> In-Reply-To: <20190315204327.GE47591@google.com> On 2019.03.15 13:43, Josh Steadmon wrote: > On 2019.03.14 00:49, Ævar Arnfjörð Bjarmason wrote: > > > > On Thu, Mar 14 2019, Josh Steadmon wrote: > > > > > When the value of a trace2 environment variable contains instances of > > > the string "%ISO8601%", expand them into the current UTC timestamp in > > > ISO 8601 format. > > > > Any reason not to just support feeding the path to strbuf_addftime(), to > > e.g. support a daily/hourly log? > > No reason not to. Seems reasonable to me. Although as Junio says elsewhere in this thread, it's possible that we may want to support fields other than timestamps.