From: Jeff King Date: Sun, 03 Mar 2019 17:45:01 GMT Subject: Re: [PATCH v2 2/2] tests: introduce --stress-jobs= Message-ID: <20190303174501.GG23811@sigill.intra.peff.net> In-Reply-To: <074628c22b2df82280b06db604196f25300e8f87.1551624293.git.gitgitgadget@gmail.com> On Sun, Mar 03, 2019 at 06:44:55AM -0800, Johannes Schindelin via GitGitGadget wrote: > diff --git a/t/test-lib.sh b/t/test-lib.sh > index ab7f27ec6a..6e557982a2 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -142,10 +142,16 @@ do > --stress) > stress=t ;; > --stress=*) > + echo "error: --stress does not accept an argument: '$opt'" >&2 > + echo "did you mean --stress-jobs=${opt#*=} or --stress-limit=${opt#*=}?" >&2 > + exit 1 This seems reasonable. I was all set to argue that "--stress-limit" is much more common than "--stress-jobs", but I see Gábor just made the opposite argument. So maybe just informing the user is the right thing. :) -Peff