From: Jeff King Date: Thu, 28 Feb 2019 21:26:37 GMT Subject: Re: [PATCH RFC 07/20] cat-file: remove skip_object_info Message-ID: <20190228212637.GG12723@sigill.intra.peff.net> In-Reply-To: <0102016915f49a52-284c872e-17ab-4bfb-befd-2720b48fcbbe-000000@eu-west-1.amazonses.com> On Fri, Feb 22, 2019 at 04:05:45PM +0000, Olga Telezhnaya wrote: > Get rid of skip_object_info field in struct expand_data. > expand_data may be global further as we use it in ref-filter also, > so we need to remove cat-file specific fields from it. > > All globals that I add through this patch will be deleted in the end, > so treat it just as the middle step. OK, makes sense in the same way that the previous patch does. I actually wonder if it would make sense to just do them all in a single patch; the justification is identical for all cases. But I'm also OK leaving them separate. -Peff