From: Jeff King <peff@peff.net>
Date: Thu, 28 Feb 2019 21:11:23 GMT
Subject: Re: [PATCH RFC 04/20] for-each-ref: tests for new atom %(rest) added
Message-ID: <20190228211122.GD12723@sigill.intra.peff.net>
In-Reply-To: <0102016915f49a4f-cdb13ec8-58ea-47aa-a64a-517db120961e-000000@eu-west-1.amazonses.com>

On Fri, Feb 22, 2019 at 04:05:45PM +0000, Olga Telezhnaya wrote:

> Add tests for new formatting atom %(rest).
> We need this atom for cat-file command.

While I do normally encourage splitting up commits, in this case I think
it would make sense to squash this together with patch 3. There's
nothing to say here about what %(rest) is that isn't already said in
that commit message.

That said, I'm still not sure that for-each-ref should be supporting
%(rest) at all. We should hopefully already have coverage of cat-file
using "%(rest)" (and if not, we should add some to make sure it's not
regressed by the conversion).

-Peff