From: Jeff King <peff@peff.net>
Date: Thu, 28 Feb 2019 21:06:34 GMT
Subject: Re: [PATCH RFC 02/20] ref-filter: rename field in ref_array_item stuct
Message-ID: <20190228210633.GB12723@sigill.intra.peff.net>
In-Reply-To: <0102016915f49a3c-5b22158a-2d4f-4611-9239-8388af61fd8f-000000@eu-west-1.amazonses.com>

On Fri, Feb 22, 2019 at 04:05:45PM +0000, Olga Telezhnaya wrote:

> Rename objectname field to oid in struct ref_array_item.
> We usually use objectname word for string representation
> of object id, so oid explains the content better.

OK. I suspect the original was selected to match the %(objectname)
placeholder. But I agree that "oid" is the more common variable name,
and I think the connection between the placeholder and the variable
should be pretty clear.

-Peff