From: Jeff King <peff@peff.net>
Date: Sat, 23 Feb 2019 13:23:40 GMT
Subject: Re: [PATCH v2 2/6] Makefile: move "strip" assignment down from flags
Message-ID: <20190223132340.GB22403@sigill.intra.peff.net>
In-Reply-To: <4821a31a-f5ee-39ef-5302-8b71430815fe@ramsayjones.plus.com>

On Fri, Feb 22, 2019 at 09:58:14PM +0000, Ramsay Jones wrote:

> > This might annoy somebody expecting $STRIP in the environment to have
> > precedence. But I agree that consistency is probably our best strategy
> > here, and I don't see any reason the same argument would not apply to
> > $SPATCH, or $CC for that matter.
> > 
> > (So I could see an argument for moving them all to "?=", but that can
> > create its own confusion as environment variables accidentally start
> > taking effect).
> 
> $STRIP and $SPATCH will work OK, but you would be disappointed
> with $CC (or any other variable from make's built-in database). ;-)

Oof. That's confusing. All the more reason not to go in the direction of
"?=". Thanks for an interesting tidbit.

-Peff