From: Jeff King <peff@peff.net>
Date: Fri, 22 Feb 2019 15:18:34 GMT
Subject: Re: [PATCH v2 2/6] Makefile: move "strip" assignment down from flags
Message-ID: <20190222151834.GA21524@sigill.intra.peff.net>
In-Reply-To: <20190222144127.32248-3-avarab@gmail.com>

On Fri, Feb 22, 2019 at 03:41:23PM +0100, Ævar Arnfjörð Bjarmason wrote:

> Move the assignment of the "STRIP" variable down to where we're
> setting variables with the names of other programs.
> 
> For consistency with those use "=" for the assignment instead of
> "?=". I can't imagine why this would need to be different than the
> rest, and 4dc00021f7 ("Makefile: add 'strip' target", 2006-01-12)
> which added it doesn't provide an explanation.

This might annoy somebody expecting $STRIP in the environment to have
precedence. But I agree that consistency is probably our best strategy
here, and I don't see any reason the same argument would not apply to
$SPATCH, or $CC for that matter.

(So I could see an argument for moving them all to "?=", but that can
create its own confusion as environment variables accidentally start
taking effect).

-Peff