From: Josh Steadmon Date: Fri, 22 Feb 2019 00:37:06 GMT Subject: Re: [PATCH 0/2] BSD portability fixes for 2.21.0-rc2 Message-ID: <20190222003706.GA159944@google.com> In-Reply-To: <20190221192849.6581-1-avarab@gmail.com> On 2019.02.21 20:28, Ævar Arnfjörð Bjarmason wrote: > Last-minute fixes for two issues new in 2.21, not in 2.20. > > This fixes a NetBSD portability issue I noted in > https://public-inbox.org/git/87d0nm5x1d.fsf@evledraar.gmail.com/ > thanks to SZEDER for the help. > > Then there's a another fix for a test breaking on OpenBSD due to > recently merged unportable regex syntax. > > Ævar Arnfjörð Bjarmason (2): > tests: fix unportable "\?" and "\+" regex syntax > commit-graph tests: fix cryptic unportable "dd" invocation > > t/t5318-commit-graph.sh | 3 ++- > t/t6120-describe.sh | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > > -- > 2.21.0.rc0.258.g878e2cd30e > These both look good to me. Thanks! Reviewed-by: Josh Steadmon