From: Jeff King <peff@peff.net>
Date: Wed, 13 Feb 2019 06:49:06 GMT
Subject: Re: [PATCH v3 4/4] tests: define GIT_TEST_SIDEBAND_ALL
Message-ID: <20190213064906.GA29560@sigill.intra.peff.net>
In-Reply-To: <20190129232732.GB218214@google.com>

On Tue, Jan 29, 2019 at 03:27:32PM -0800, Jonathan Nieder wrote:

> Jonathan Tan wrote:
> 
> > --- a/t/lib-httpd/apache.conf
> > +++ b/t/lib-httpd/apache.conf
> > @@ -78,6 +78,7 @@ PassEnv GNUPGHOME
> >  PassEnv ASAN_OPTIONS
> >  PassEnv GIT_TRACE
> >  PassEnv GIT_CONFIG_NOSYSTEM
> > +PassEnv GIT_TEST_SIDEBAND_ALL
> 
> This is producing
> 
>  [env:warn] [pid 248632] AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined
> 
> when tests are run with "prove".
> 
> Should we set the envvar unconditionally in lib-httpd.sh?

Yes, that's the same solution we've had to use for GIT_VALGRIND, etc. I
don't think there's an easier way.

-Peff