From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 12 Feb 2019 00:53:29 GMT
Subject: Re: [PATCH v3] utf8: handle systems that don't write BOM for UTF-16
Message-ID: <20190212005329.GD684736@genre.crustytoothpaste.net>
In-Reply-To: <xmqqtvh9g857.fsf@gitster-ct.c.googlers.com>

On Mon, Feb 11, 2019 at 04:31:00PM -0800, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> >> -       cat lf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >lf.utf${i}.raw &&
> >> -       cat crlf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >crlf.utf${i}.raw &&
> >> +       cat lf.utf8.raw | eval "write_utf${i}" >lf.utf${i}.raw &&
> >> +       cat crlf.utf8.raw | eval "write_utf${i}" >crlf.utf${i}.raw &&
> >>         cp crlf.utf${i}.raw eol.utf${i} &&
> >> 
> >>         cat >expectIndexLF <<-EOF &&
> >
> > I'll squash in this fix, thanks.
> 
> Thanks, all.  In the meantime, what I've pushed out has this
> applied immediately on top.  Unless there is anything else, I could
> squash it in in my next pushout I plan to do tonight, before getting
> ready to tag -rc1 tomorrow.

I've just sent a v4 with this squashed in. Whether you want to pick that
up or squash this into v3 is up to you.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204