From: Jeff King <peff@peff.net>
Date: Tue, 29 Jan 2019 22:35:30 GMT
Subject: Re: [PATCH v3 2/3] Setup working tree in describe
Message-ID: <20190129223529.GB1895@sigill.intra.peff.net>
In-Reply-To: <CAPig+cRUCmaiYqKG6ON==g1sFph-hz6nK5fTYc-9w2JaNFmdLA@mail.gmail.com>

On Tue, Jan 29, 2019 at 03:53:40PM -0500, Eric Sunshine wrote:

> > > The implementation of --broken uses diff-index which calls
> > > setup_work_tree() itself.
> >
> > If I hadn't just read the rest of the thread, I'd probably wonder why we
> > are talking about --broken at all. Maybe:
> >
> >   The --broken option similarly needs a working tree. But because the
> >   current implementation calls an external diff-index to do the work,
> >   we don't have to bother setting up the working tree in the
> >   git-describe process.
> 
> This rewrite left me slightly in the dark since I had to infer that
> git-diff-index calls setup_work_tree() itself. Perhaps:
> 
>     ...an external diff-index to do the work, which itself calls
>     setup_work_tree(), we don't have to bother...
> 
> But that's minor.

Yeah, my reasoning was that we handed off to diff-index, so if it
doesn't work, then it has its own bug. ;) But I agree it is probably
better to just be explicit.

-Peff