From: Jeff King <peff@peff.net>
Date: Tue, 29 Jan 2019 13:12:43 GMT
Subject: Re: [PATCH v3 3/3] Add test for describe with a bare repository
Message-ID: <20190129131243.GC22211@sigill.intra.peff.net>
In-Reply-To: <20190129051859.12830-3-koraktor@gmail.com>

On Tue, Jan 29, 2019 at 06:18:59AM +0100, Sebastian Staudt wrote:

> This ensures that nothing breaks the basic functionality of describe for
> bare repositories. Please note that --broken and --dirty need a working
> tree.

Makes sense.

> +test_expect_success 'describe works from outside repo using --git-dir' "
> +  git clone --bare '$TRASH_DIRECTORY' '$TRASH_DIRECTORY/bare' &&
> +  git --git-dir '$TRASH_DIRECTORY/bare' describe
> +"

What the test is doing seems sane, but the same quoting comments from
the earlier patch apply.

-Peff