From: William Hubbs <williamh@gentoo.org>
Date: Sat, 26 Jan 2019 01:06:32 GMT
Subject: Re: [PATCH v2 2/2] tests: add test for separate author and committer idents
Message-ID: <20190126010632.GA4000@whubbs1.gaikai.biz>
In-Reply-To: <875zuc49uj.fsf@evledraar.gmail.com>

On Sat, Jan 26, 2019 at 12:05:08AM +0100, Ævar Arnfjörð Bjarmason wrote:
> 
> On Fri, Jan 25 2019, William Hubbs wrote:

...

> > +	sane_unset GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL &&
> > +	sane_unset GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL &&
> 
> Fine, but FYI sets these variables for the rest of the test.

I'm not quite sure what you mean by this. I want the environment
variables to be *unset*. I don't want them to override anything in the
config file for this test.

Are you saying they will not be set for the test unless I set them,
so I don't need the SANE_UNSET calls?

Thanks,

William