From: brian m. carlson Date: Fri, 25 Jan 2019 02:04:52 GMT Subject: Re: [PATCH v1] git-instaweb: Add Python builtin http.server support Message-ID: <20190125020451.GU423984@genre.crustytoothpaste.net> In-Reply-To: <20190124161331.25945-1-arti.zirk@gmail.com> On Thu, Jan 24, 2019 at 06:13:31PM +0200, Arti Zirk wrote: > With this patch it is possible to launch git-instaweb by using > Python 3 http.server CGI handler via `-d python` option. > > git-instaweb generates a small wrapper around the http.server > (in GIT_DIR/gitweb/) that address a limitation of the CGI handler > where CGI scripts have to be in a cgi-bin subdirectory and > directory index can't be easily changed. To keep the implementation > small, gitweb is running on url `/cgi-bin/gitweb.cgi` and an automatic > redirection is done when opening `/`. > > Python 3 is by default installed on most modern Linux distributions > which enables running `git instaweb -d python` without needing > anything else. I'm glad we're using Python 3 here, but I wonder if the name "python" will lead people to think it will work with Python 2 as well. There are people using up-to-date Git on systems like CentOS 6 and 7, where Python 3 is not generally available. Could we call this "python3" instead, or provide some other way to communicate this to the user? -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204